Fix missing query string conversion in TomcatService #74
+70
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: TomcatServiceInvocationHandler does not set the 'queryString' property of Coyote Request object during the conversion. Modifications: - Call Request.queryString().setString() if HttpRequest.uri() has a query string - Add the test cases for GET and POST with query parameters Result: Web application gets query parameters correctly.
|
@delegacy PTAL |
| public void testGetQueryString() throws Exception { | ||
| try (CloseableHttpClient hc = HttpClients.createMinimal()) { | ||
| try (CloseableHttpResponse res = hc.execute( | ||
| new HttpGet(uri("/tc/query_string.jsp?foo=%31&bar=%32")))) { |
There was a problem hiding this comment.
These URL encoded values are intentional?
There was a problem hiding this comment.
Yes, to test if they are decoded properly.
|
LGTM. |
delegacy
added a commit
that referenced
this pull request
Dec 21, 2015
Fix missing query string conversion in TomcatService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
TomcatServiceInvocationHandler does not set the 'queryString' property
of Coyote Request object during the conversion.
Modifications:
query string
Result:
Web application gets query parameters correctly.